feat: no strict dep5 parsing #805
Conversation
Since version 0.1.47 of python-debian the dep5 parsing is strict. This is causing issues for certain users that have multiple Copyright statements in their Dep5 file. Disablng strictness removes the issue for those users. Closes #803 Signed-off-by: Nico Rikken <[email protected]>
Tests to ensure that all Copyright information from the .reuse/dep5 file is taken into account. It contains 2 testcases, for both strictly and non-strictly formatted dep5 files. The latter being present in the wild, based on comments in #803 Signed-off-by: Nico Rikken <[email protected]>
|
This fails in its current state as multiple copyright fields are simply ignored. |
Generating a file-report with a non-strict dep5 containing multiple Copyright entries will leave part of the Copyright information to be ignored. The updated test reflects that behavior and now no longer fails. Signed-off-by: Nico Rikken <[email protected]>
Update line wrap length and disable pylint for the dep5 file content. Signed-off-by: Nico Rikken <[email protected]>
I found this while working on something else. Tiny commit; why not.
|
I am no longer certain if I want to merge this. I took a look at python-debian 0.1.38 (the lowest compatible version according to pyproject.toml), and strict mode was always enabled. https://salsa.debian.org/python-debian-team/python-debian/-/blob/0.1.38/lib/debian/copyright.py#L130 I have to assume that python-debian recently included 'no duplicate fields' in their checks, which is fine, but simply disabling this now results in other breakage. Specifically, the following checks (in 0.1.38, but I'm going to assume that they exist after 0.1.38 also): _complain('Non-header paragraph has neither "Files" nor '
'"License" fields', strict)
[...]
if 'Copyright' not in data:
_complain('Files paragraph missing Copyright field', strict)
if 'License' not in data:
_complain('Files paragraph missing License field', strict)
if not self.files:
_complain('Files paragraph has empty Files field', strict)I am fairly certain that we do need/want these checks. |
|
@carmenbianca Good catch, then downgrading python-debian seems more appropriate. |
Since version 0.1.47 of python-debian the dep5 parsing is strict. This is causing issues for certain users that have multiple Copyright statements in their Dep5 file. Disablng strictness removes the issue for those users.
Closes #803